Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating a cron-workflow to run the cronjob #61

Closed
wants to merge 1 commit into from
Closed

creating a cron-workflow to run the cronjob #61

wants to merge 1 commit into from

Conversation

Gregory-Pereira
Copy link
Member

Related Issues and Dependencies

Partially addresses: thoth-station/thoth-application#2513

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Implementing a cronWorkflow to run the job.

Description

I was wondering if I need to be able to use oc login inside of the container before it runs the script, otherwise how else would it know where to push the changes to?

@sesheta
Copy link
Member

sesheta commented Apr 19, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign goern after the PR has been reviewed.
You can assign the PR to them by writing /assign @goern in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta requested a review from KPostOffice April 19, 2022 17:25
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2022
harshad16
harshad16 requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start,
lets move this to thoth-application repo, as we maintain all the manifest there.
and close this pr.

openshift/cronworkflow.yaml
container:
image: quay.io/thoth-station/sync-job:v0.2.3-dev
command: ["oc", "process"]
args: ["-p IMAGE_VERSION='v0.2.3-dev'", "-p THOTH_SYNC_FORCE='0'", "-p THOTH_SYNC_GRACEFUL='0'", "-p THOTH_SYNC_DEBUG='0'", "-f openshift.yaml", " | oc apply -f -"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this are env var, lets add them as env var https://argoproj.github.io/argo-workflows/fields/#fields_101

@Gregory-Pereira
Copy link
Member Author

good start, lets move this to thoth-application repo, as we maintain all the manifest there. and close this pr.

Closing due to PR living in the wrong repo.

@Gregory-Pereira Gregory-Pereira mentioned this pull request Apr 20, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 requested changes

@goern goern Awaiting requested review from goern goern is a code owner

@fridex fridex Awaiting requested review from fridex

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gregory-Pereira @sesheta @harshad16